Add enhancement proposal document and template #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
sjberman
requested changes
May 25, 2023
|
Once #669 is merged, I'll update this PR and add a link to this doc to CONTRIBUTING.md |
brianehlert
requested changes
May 30, 2023
|
May seem like a minor thing, but can we replace any mention of the abbreviation "EP" (including the directory) to "Enhancement Proposal"? Using abbreviations is another barrier to understanding what is going on in the community that we can easily remove. |
mpstefan
suggested changes
May 30, 2023
pleshakov
suggested changes
May 30, 2023
kate-osborn
force-pushed
the
docs/enhancement-proposal
branch
from
f0def49 to
02f2aa0
Compare
sjberman
approved these changes
May 31, 2023
kate-osborn
force-pushed
the
docs/enhancement-proposal
branch
from
0c8536d to
be9560b
Compare
pleshakov
approved these changes
Jun 1, 2023
kate-osborn
commented
Jun 1, 2023
mpstefan
suggested changes
Jun 1, 2023
brianehlert
approved these changes
Jun 2, 2023
sjberman
approved these changes
Jun 6, 2023
kate-osborn
force-pushed
the
docs/enhancement-proposal
branch
from
2021518 to
e629247
Compare
mpstefan
approved these changes
Jun 7, 2023
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Michael Pleshakov <[email protected]>
kate-osborn
force-pushed
the
docs/enhancement-proposal
branch
from
e629247 to
4e63fb5
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: NKG does not have a process defined for enhancement proposals. Solution: Add a document that describes our Enhancement Proposal process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds Enhancement Proposal (EP) process document and template. The process and template are based on GEPs but also include some of our design doc requirements.
This is just a starting point. I'm looking for feedback on the process and am open to making any changes.
Closes #672
Checklist
Before creating a PR, run through this checklist and mark each as complete.